[webkit-reviews] review granted: [Bug 197615] [PlayStation] JSC Stress tests failing due to timezone printing : [Attachment 369126] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 6 10:06:13 PDT 2019


Ross Kirsling <ross.kirsling at sony.com> has granted  review:
Bug 197615: [PlayStation] JSC Stress tests failing due to timezone printing
https://bugs.webkit.org/show_bug.cgi?id=197615

Attachment 369126: Patch

https://bugs.webkit.org/attachment.cgi?id=369126&action=review




--- Comment #2 from Ross Kirsling <ross.kirsling at sony.com> ---
Comment on attachment 369126
  --> https://bugs.webkit.org/attachment.cgi?id=369126
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=369126&action=review

> JSTests/ChakraCore.yaml:693
> +	     runChakra :baseline, "NoException",
"InternalToString.playstation.baseline", []

The bare .baseline files are as-is from ChakraCore, so we should mark this
.baseline-jsc.
I can't seem to find a precedent for a platform-specific baseline though --
maybe .baseline-jsc-playstation, so that we keep the more specific stuff at the
very end?


More information about the webkit-reviews mailing list