[webkit-reviews] review granted: [Bug 197573] [iOS] outlook.live.com: Compose email frame not fully visible and not scrollable : [Attachment 369017] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 3 16:53:28 PDT 2019


Wenson Hsieh <wenson_hsieh at apple.com> has granted zalan <zalan at apple.com>'s
request for review:
Bug 197573: [iOS] outlook.live.com: Compose email frame not fully visible and
not scrollable
https://bugs.webkit.org/show_bug.cgi?id=197573

Attachment 369017: Patch

https://bugs.webkit.org/attachment.cgi?id=369017&action=review




--- Comment #7 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 369017
  --> https://bugs.webkit.org/attachment.cgi?id=369017
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=369017&action=review

> Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:2885
> +    viewportChanged |=
m_viewportConfiguration.setViewLayoutSize(adjustedViewLayoutSize(viewLayoutSize
));

Nit - I have a slight preference for a more explicit name that makes it clear
that this is only here to support hard-coded site-specific layout width quirks,
and shouldn't be used for more general purposes. How about something like
viewLayoutSizeAdjustedForQuirks?


More information about the webkit-reviews mailing list