[webkit-reviews] review granted: [Bug 197584] [JSC] Need to emit SetLocal if we emit MovHint in DFGByteCodeParser : [Attachment 369014] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Yusuke Suzuki <ysuzuki at apple.com>'s
request for review:
Bug 197584: [JSC] Need to emit SetLocal if we emit MovHint in DFGByteCodeParser
https://bugs.webkit.org/show_bug.cgi?id=197584

Attachment 369014: Patch

https://bugs.webkit.org/attachment.cgi?id=369014&action=review




--- Comment #4 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 369014
  --> https://bugs.webkit.org/attachment.cgi?id=369014
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=369014&action=review

> Source/JavaScriptCore/ChangeLog:10
> +	   and SetLocal are needed to be a pair in DFGByteCodeParser because we
rely on this assumption in SSA conversion phase. SSA conversion phase always
emit KillStack

This seems weird.