[webkit-reviews] review granted: [Bug 197586] iOS JSC tests frequently exiting with execption after stress/json-stringify-string-builder-overflow.js.no-cjit-validate-phases : [Attachment 369015] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 3 16:27:14 PDT 2019


Keith Miller <keith_miller at apple.com> has granted Michael Saboff
<msaboff at apple.com>'s request for review:
Bug 197586: iOS JSC tests frequently exiting with execption after
stress/json-stringify-string-builder-overflow.js.no-cjit-validate-phases
https://bugs.webkit.org/show_bug.cgi?id=197586

Attachment 369015: Patch

https://bugs.webkit.org/attachment.cgi?id=369015&action=review




--- Comment #3 from Keith Miller <keith_miller at apple.com> ---
Comment on attachment 369015
  --> https://bugs.webkit.org/attachment.cgi?id=369015
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=369015&action=review

r=me with change.

> JSTests/stress/json-stringify-string-builder-overflow.js:4
>  //@ skip if $architecture != "arm64" and $architecture != "x86-64"

Can we remove this line since it doesn't do anything.


More information about the webkit-reviews mailing list