[webkit-reviews] review granted: [Bug 197581] Adopt AVStreamDataParser.audiovisualMIMETypes : [Attachment 369005] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 197581: Adopt AVStreamDataParser.audiovisualMIMETypes
https://bugs.webkit.org/show_bug.cgi?id=197581

Attachment 369005: Patch

https://bugs.webkit.org/attachment.cgi?id=369005&action=review




--- Comment #3 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 369005
  --> https://bugs.webkit.org/attachment.cgi?id=369005
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=369005&action=review

>
Source/WebCore/platform/graphics/avfoundation/objc/AVStreamDataParserMIMETypeCa
che.mm:77
> +    // AVStreamDataParser does not have an -isPlayableExtendedMIMEType:
method, so just replace the container type
> +    // with a valid one from AVAssetMIMETypeCache and ask that cache if it
can decode this type:

You should add a FIXME to remove this once they implement
-isPlayableExtendedMIMEType

>
Source/WebCore/platform/graphics/avfoundation/objc/AVStreamDataParserMIMETypeCa
che.mm:81
> +    ContentType originalType { mimeType };

Can't you just reuse "type" defined above?