[webkit-reviews] review granted: [Bug 197563] run-api-tests: Add --iterations and --repeat-each : [Attachment 368940] Patch

[bugzilla-daemon at webkit.org]

Aakash Jain <aakash_jain at apple.com> has granted Jonathan Bedard
<jbedard at apple.com>'s request for review:
Bug 197563: run-api-tests: Add --iterations and --repeat-each
https://bugs.webkit.org/show_bug.cgi?id=197563

Attachment 368940: Patch

https://bugs.webkit.org/attachment.cgi?id=368940&action=review




--- Comment #6 from Aakash Jain <aakash_jain at apple.com> ---
Comment on attachment 368940
  --> https://bugs.webkit.org/attachment.cgi?id=368940
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=368940&action=review

> Tools/Scripts/webkitpy/api_tests/manager.py:185
> +	   test_names = [test for test in test_names for _ in
xrange(self._options.repeat_each)]

It feels little weird to duplicate the list of test_names. Maybe a cleaner
approach would be to run a for loop, and also log a message with iteration
number, so that it's easier for someone to find out when a iteration is
complete.

> Tools/Scripts/webkitpy/api_tests/manager.py:186
> +	   test_names *= self._options.iterations

Maybe worth adding a log indicating the number of iterations.