[webkit-reviews] review granted: [Bug 197577] AVFoundation framework isn't always installed : [Attachment 368988] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 3 14:22:58 PDT 2019


Jer Noble <jer.noble at apple.com> has granted Eric Carlson
<eric.carlson at apple.com>'s request for review:
Bug 197577: AVFoundation framework isn't always installed
https://bugs.webkit.org/show_bug.cgi?id=197577

Attachment 368988: Patch

https://bugs.webkit.org/attachment.cgi?id=368988&action=review




--- Comment #3 from Jer Noble <jer.noble at apple.com> ---
Comment on attachment 368988
  --> https://bugs.webkit.org/attachment.cgi?id=368988
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=368988&action=review

r=me.

>
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStrea
mAVFObjC.mm:229
> -    return PAL::AVFoundationLibrary() && isCoreMediaFrameworkAvailable() &&
getAVSampleBufferDisplayLayerClass();
> +    return isAVFoundationFrameworkAvailable() &&
isCoreMediaFrameworkAvailable() && getAVSampleBufferDisplayLayerClass();

Why no PAL?


More information about the webkit-reviews mailing list