[webkit-reviews] review granted: [Bug 197432] [WinCairo] Implement and enable RemoteInspector Server. : [Attachment 368965] PATCH

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 3 12:56:16 PDT 2019

Ross Kirsling <ross.kirsling at sony.com> has granted Basuke Suzuki
<Basuke.Suzuki at sony.com>'s request for review:
Bug 197432: [WinCairo] Implement and enable RemoteInspector Server.

Attachment 368965: PATCH


--- Comment #13 from Ross Kirsling <ross.kirsling at sony.com> ---
Comment on attachment 368965
  --> https://bugs.webkit.org/attachment.cgi?id=368965

View in context: https://bugs.webkit.org/attachment.cgi?id=368965&action=review

r=me with nits

> Source/JavaScriptCore/inspector/remote/socket/RemoteInspectorServer.h:65
> -    void didAccept(ConnectionID, Socket::Domain) override;
> +    void didAccept(ConnectionID, ConnectionID listenerID, Socket::Domain)

You should probably label both ConnectID parameters here.

> Source/JavaScriptCore/inspector/remote/socket/RemoteInspectorSocket.h:72
> -Optional<PlatformSocketType> listen(uint16_t port);
> +Optional<PlatformSocketType> listen(const char* address, uint16_t port);

This parameter is now called addressStr, though I suppose the names here could
just be omitted.

More information about the webkit-reviews mailing list