[webkit-reviews] review granted: [Bug 197389] Use more efficient path resolution logic in SandboxExtensions : [Attachment 368872] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 3 11:28:34 PDT 2019

Maciej Stachowiak <mjs at apple.com> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 197389: Use more efficient path resolution logic in SandboxExtensions

Attachment 368872: Patch


--- Comment #27 from Maciej Stachowiak <mjs at apple.com> ---
Comment on attachment 368872
  --> https://bugs.webkit.org/attachment.cgi?id=368872

View in context: https://bugs.webkit.org/attachment.cgi?id=368872&action=review


The suggestion to entirely remove the symlink resolution here, and to move the
stringByResolvingSymlinksInPath() function to another file, should be
considered as follow-up changes.

> Source/WebKit/Shared/Cocoa/SandboxExtensionCocoa.mm:247
> +    String resolvedPath = [(NSString *)path

Optional suggestion: It might actually make sense to call the new
stringByResolvingSymlinksInPath() function here, since it does the same
NSString/String conversion.

More information about the webkit-reviews mailing list