[webkit-reviews] review granted: [Bug 197389] Use more efficient path resolution logic in SandboxExtensions : [Attachment 368872] Patch

[bugzilla-daemon at webkit.org]

Maciej Stachowiak <mjs at apple.com> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 197389: Use more efficient path resolution logic in SandboxExtensions
https://bugs.webkit.org/show_bug.cgi?id=197389

Attachment 368872: Patch

https://bugs.webkit.org/attachment.cgi?id=368872&action=review




--- Comment #27 from Maciej Stachowiak <mjs at apple.com> ---
Comment on attachment 368872
  --> https://bugs.webkit.org/attachment.cgi?id=368872
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=368872&action=review

r=me

The suggestion to entirely remove the symlink resolution here, and to move the
stringByResolvingSymlinksInPath() function to another file, should be
considered as follow-up changes.

> Source/WebKit/Shared/Cocoa/SandboxExtensionCocoa.mm:247
> +    String resolvedPath = [(NSString *)path
stringByResolvingSymlinksInPath];

Optional suggestion: It might actually make sense to call the new
stringByResolvingSymlinksInPath() function here, since it does the same
NSString/String conversion.