[webkit-reviews] review granted: [Bug 197228] TypeArrays should not store properties that are canonical numeric indices : [Attachment 368929] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Tadeu Zagallo
<tzagallo at apple.com>'s request for review:
Bug 197228: TypeArrays should not store properties that are canonical numeric
indices
https://bugs.webkit.org/show_bug.cgi?id=197228

Attachment 368929: Patch

https://bugs.webkit.org/attachment.cgi?id=368929&action=review




--- Comment #40 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 368929
  --> https://bugs.webkit.org/attachment.cgi?id=368929
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=368929&action=review

r=me

> Source/JavaScriptCore/runtime/JSGenericTypedArrayViewInlines.h:370
> +	   slot.setValue(thisObject, PropertyAttribute::DontDelete |
PropertyAttribute::ReadOnly, jsUndefined());
> +	   return false;

so Object.hasOwnProperty(typedArray, "-0") returns true?

and Object.getOwnPropertyDescriptor(typedArray, "-0").configurable == false and
writable == false?

Do we have tests for this? (and other canonical numeric index strings)