[webkit-reviews] review granted: [Bug 197464] Cache.add and Cache.addAll should compute a correct response body size : [Attachment 368730] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri May 3 08:40:13 PDT 2019
Chris Dumez <cdumez at apple.com> has granted youenn fablet <youennf at gmail.com>'s
request for review:
Bug 197464: Cache.add and Cache.addAll should compute a correct response body
size
https://bugs.webkit.org/show_bug.cgi?id=197464
Attachment 368730: Patch
https://bugs.webkit.org/attachment.cgi?id=368730&action=review
--- Comment #3 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 368730
--> https://bugs.webkit.org/attachment.cgi?id=368730
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=368730&action=review
> Source/WebCore/Modules/cache/DOMCache.cpp:179
> + DOMCacheEngine::ResponseBody body = WTFMove(data);
Does not seem like we need this local variable.
> Source/WebCore/Modules/cache/DOMCache.cpp:180
> + record.responseBodySize =
m_domCache->connection().computeRecordBodySize(response, body);
s/body/data
> Source/WebCore/Modules/cache/DOMCache.cpp:181
> + record.responseBody = WTFMove(body);
s/body/data
> Source/WebCore/Modules/cache/DOMCache.cpp:237
> + auto taskHandler = FetchTasksHandler::create(makeRef(*this), [this,
promise = WTFMove(promise)](ExceptionOr<Vector<Record>>&& result) mutable {
s/makeRef(*this)/*this
More information about the webkit-reviews
mailing list