[webkit-reviews] review granted: [Bug 197551] Web Inspector: Dark Mode: borders between section should be lighter than background : [Attachment 368899] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 2 22:50:12 PDT 2019


Joseph Pecoraro <joepeck at webkit.org> has granted Nikita Vasilyev
<nvasilyev at apple.com>'s request for review:
Bug 197551: Web Inspector: Dark Mode: borders between section should be lighter
than background
https://bugs.webkit.org/show_bug.cgi?id=197551

Attachment 368899: Patch

https://bugs.webkit.org/attachment.cgi?id=368899&action=review




--- Comment #3 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 368899
  --> https://bugs.webkit.org/attachment.cgi?id=368899
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=368899&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/DetailsSection.css:34
> +    border-color: var(--text-color-quaternary);

Hmm, having a "border-color" be a --text-color blows my mind but it seems like
something we do _a lot_.


More information about the webkit-reviews mailing list