[webkit-reviews] review granted: [Bug 197540] Need additional UIPreviewAction information in WKImagePreviewViewController : [Attachment 368866] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 2 22:00:13 PDT 2019


Wenson Hsieh <wenson_hsieh at apple.com> has granted Dean Jackson
<dino at apple.com>'s request for review:
Bug 197540: Need additional UIPreviewAction information in
WKImagePreviewViewController
https://bugs.webkit.org/show_bug.cgi?id=197540

Attachment 368866: Patch

https://bugs.webkit.org/attachment.cgi?id=368866&action=review




--- Comment #7 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 368866
  --> https://bugs.webkit.org/attachment.cgi?id=368866
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=368866&action=review

> Source/WebKit/UIProcess/WKImagePreviewViewController.mm:38
> +#define ADDITIONAL_PREVIEW_ACTION_ITEM_INFO

Nit - you might want to consider making this a method or function instead of a
macro.


More information about the webkit-reviews mailing list