[webkit-reviews] review granted: [Bug 197543] [WebAuthN] A focused document should be required : [Attachment 368867] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 2 19:42:07 PDT 2019

Brent Fulgham <bfulgham at webkit.org> has granted Jiewen Tan
<jiewen_tan at apple.com>'s request for review:
Bug 197543: [WebAuthN] A focused document should be required

Attachment 368867: Patch


--- Comment #4 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 368867
  --> https://bugs.webkit.org/attachment.cgi?id=368867

View in context: https://bugs.webkit.org/attachment.cgi?id=368867&action=review

> Source/WebCore/Modules/webauthn/AuthenticatorCoordinator.cpp:-171
> -    // For better performance, transports of options.excludeCredentials are
checked in LocalAuthenticator.

Why are you removing this comment. At least we should say we aren't
implementing these steps and why.

> Source/WebCore/Modules/webauthn/AuthenticatorCoordinator.cpp:-243
> -    if (!m_client)  {


More information about the webkit-reviews mailing list