[webkit-reviews] review granted: [Bug 197532] REGRESSION: Layout test editing/selection/ios/selection-after-changing-text-with-callout-menu.html is failing : [Attachment 368841] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 197532: REGRESSION: Layout test
editing/selection/ios/selection-after-changing-text-with-callout-menu.html is
failing
https://bugs.webkit.org/show_bug.cgi?id=197532

Attachment 368841: Patch

https://bugs.webkit.org/attachment.cgi?id=368841&action=review




--- Comment #2 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 368841
  --> https://bugs.webkit.org/attachment.cgi?id=368841
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=368841&action=review

> Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm:1110
> -void WebPageProxy::editorStateChanged(const EditorState& editorState)
> +void WebPageProxy::setEditorState(const EditorState& editorState)

Maybe updateEditorState? It's not like we're setting a new editor state object.
EditorState is always there but we're updating its content.