[webkit-reviews] review granted: [Bug 197510] -[WKWebsiteDataStore removeDataOfTypes:forDataRecords:completionHandler:] doesn't delete _WKWebsiteDataTypeCredentials : [Attachment 368772] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted Per Arne Vollan
<pvollan at apple.com>'s request for review:
Bug 197510: -[WKWebsiteDataStore
removeDataOfTypes:forDataRecords:completionHandler:] doesn't delete
_WKWebsiteDataTypeCredentials
https://bugs.webkit.org/show_bug.cgi?id=197510

Attachment 368772: Patch

https://bugs.webkit.org/attachment.cgi?id=368772&action=review




--- Comment #3 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 368772
  --> https://bugs.webkit.org/attachment.cgi?id=368772
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=368772&action=review

LGTM, can this be used instead of WKProcessPool._removeCredential:... for
testing?  If so, we should remove that SPI.  This is much better.

> Source/WebKit/NetworkProcess/cocoa/NetworkProcessCocoa.mm:225
> +void NetworkProcess::removeCredentialsWithOrigins(const
Vector<WebCore::SecurityOriginData>& origins, CompletionHandler<void()>&&
completionHandler)

Add a stub implementation for non-Cocoa ports.