[webkit-reviews] review granted: [Bug 197481] [WebAuthN] Adopt SecurityOrigin::isMatchingRegistrableDomainSuffix() : [Attachment 368722] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Jiewen Tan
<jiewen_tan at apple.com>'s request for review:
Bug 197481: [WebAuthN] Adopt
SecurityOrigin::isMatchingRegistrableDomainSuffix()
https://bugs.webkit.org/show_bug.cgi?id=197481

Attachment 368722: Patch

https://bugs.webkit.org/attachment.cgi?id=368722&action=review




--- Comment #2 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 368722
  --> https://bugs.webkit.org/attachment.cgi?id=368722
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=368722&action=review

Looks good! I would adjust the comments slightly, but no further review is
needed.

> Source/WebCore/Modules/webauthn/AuthenticatorCoordinator.cpp:131
> +    // be domains or IP addresses.
https://url.spec.whatwg.org/#url-representation

I think it might be simpler to just say: "The effective domain may be
represented in various manners, such as a domain or an ip address. Only the
domain format of host is permitted in WebAuthN.

> Source/WebCore/Modules/webauthn/AuthenticatorCoordinator.cpp:198
> +    // be a domain or an IP address.
https://url.spec.whatwg.org/#url-representation

Ditto: I think it might be simpler to just say: "The effective domain may be
represented in various manners, such as a domain or an ip address. Only the
domain format of host is permitted in WebAuthN.