[webkit-reviews] review granted: [Bug 197439] RemoteInspector::updateAutomaticInspectionCandidate should have a default implementation. : [Attachment 368721] Patch

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has granted Ross Kirsling
<ross.kirsling at sony.com>'s request for review:
Bug 197439: RemoteInspector::updateAutomaticInspectionCandidate should have a
default implementation.
https://bugs.webkit.org/show_bug.cgi?id=197439

Attachment 368721: Patch

https://bugs.webkit.org/attachment.cgi?id=368721&action=review




--- Comment #12 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 368721
  --> https://bugs.webkit.org/attachment.cgi?id=368721
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=368721&action=review

r=me

> Source/JavaScriptCore/inspector/remote/RemoteInspector.cpp:113
> +bool RemoteInspector::updateTargetInternal(RemoteControllableTarget* target)

This is an odd name.  How about `updateListingForTarget` or `updateTargetMap`?

> Source/JavaScriptCore/inspector/remote/RemoteInspector.cpp:-111
> -    {

NIT: I realize this block is unnecessary, but I wouldn't change it for the sake
of keeping the diff cleaner :P