[webkit-reviews] review granted: [Bug 196583] TestWebKitAPI config.h should be aware of what suite is being built : [Attachment 368679] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 1 14:59:19 PDT 2019


Konstantin Tokarev <annulen at yandex.ru> has granted Don Olmstead
<don.olmstead at sony.com>'s request for review:
Bug 196583: TestWebKitAPI config.h should be aware of what suite is being built
https://bugs.webkit.org/show_bug.cgi?id=196583

Attachment 368679: Patch

https://bugs.webkit.org/attachment.cgi?id=368679&action=review




--- Comment #45 from Konstantin Tokarev <annulen at yandex.ru> ---
Comment on attachment 368679
  --> https://bugs.webkit.org/attachment.cgi?id=368679
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=368679&action=review

LGTM except that letter case error

> Tools/TestWebKitAPI/PlatformWin.cmake:98
> +set(TestWebcore_OUTPUT_NAME TestWebCore${DEBUG_SUFFIX})

Wrong letter case in TestWebcore_OUTPUT_NAME


More information about the webkit-reviews mailing list