[webkit-reviews] review granted: [Bug 197330] Web Inspector: DOM: dragging a node to the console should log the node : [Attachment 368414] Patch

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at apple.com> has granted Devin Rousso
<drousso at apple.com>'s request for review:
Bug 197330: Web Inspector: DOM: dragging a node to the console should log the
node
https://bugs.webkit.org/show_bug.cgi?id=197330

Attachment 368414: Patch

https://bugs.webkit.org/attachment.cgi?id=368414&action=review




--- Comment #2 from Timothy Hatcher <timothy at apple.com> ---
Comment on attachment 368414
  --> https://bugs.webkit.org/attachment.cgi?id=368414
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=368414&action=review

> Source/WebInspectorUI/UserInterface/Views/LogContentView.js:636
> +		   let text = domNode.nodeType() === Node.ELEMENT_NODE ?
WI.UIString("Selected Element") : WI.UIString("Selected Node");

"Selected Node/Element" => "Dropped Node/Element"?

> Source/WebInspectorUI/UserInterface/Views/QuickConsole.js:189
> +		   let text = domNode.nodeType() === Node.ELEMENT_NODE ?
WI.UIString("Selected Element") : WI.UIString("Selected Node");

Ditto.