[webkit-reviews] review granted: [Bug 197342] [iOS] Add a version of viewport shrink-to-fit heuristics that preserves page layout : [Attachment 368604] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 197342: [iOS] Add a version of viewport shrink-to-fit heuristics that
preserves page layout
https://bugs.webkit.org/show_bug.cgi?id=197342

Attachment 368604: Patch

https://bugs.webkit.org/attachment.cgi?id=368604&action=review




--- Comment #10 from Tim Horton <thorton at apple.com> ---
Comment on attachment 368604
  --> https://bugs.webkit.org/attachment.cgi?id=368604
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=368604&action=review

> Source/WebKit/WebProcess/WebPage/WebPage.cpp:427
> +#if ENABLE_VIEWPORT_RESIZING

These should be ENABLE(), not ENABLE_

> Source/WebKit/WebProcess/WebPage/WebPage.h:1907
> +    WebCore::DeferrableOneShotTimer m_shrinkToFitContentTimer;

Doesn't even really need to be a timer, but whatever.