[webkit-reviews] review granted: [Bug 197428] XMLHttpRequest should propagate user gestures for media playback : [Attachment 368614] Patch

[bugzilla-daemon at webkit.org]

Jer Noble <jer.noble at apple.com> has granted Eric Carlson
<eric.carlson at apple.com>'s request for review:
Bug 197428: XMLHttpRequest should propagate user gestures for media playback
https://bugs.webkit.org/show_bug.cgi?id=197428

Attachment 368614: Patch

https://bugs.webkit.org/attachment.cgi?id=368614&action=review




--- Comment #8 from Jer Noble <jer.noble at apple.com> ---
Comment on attachment 368614
  --> https://bugs.webkit.org/attachment.cgi?id=368614
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=368614&action=review

> Source/WebCore/xml/XMLHttpRequest.cpp:69
> +static const Seconds maximumIntervalForUserGestureForwarding { 10_s };

Nit: I think it's really weird that there's both
`maxIntervalForUserGestureForwarding` in DOMTimer and
`maximumIntervalForUserGestureForwarding` in XMLHttpRequest, and that they're
different values. (1s vs. 10s.)

Doesn't this mean that a xhr -> timer -> xhr of less that 10s will break if the
first xhr takes > 1s?