[webkit-reviews] review granted: [Bug 196431] [iOS] Crash when changing inputmode for certain types of focusable elements : [Attachment 366370] Fixes the bug

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 196431: [iOS] Crash when changing inputmode for certain types of focusable
elements
https://bugs.webkit.org/show_bug.cgi?id=196431

Attachment 366370: Fixes the bug

https://bugs.webkit.org/attachment.cgi?id=366370&action=review




--- Comment #4 from Tim Horton <thorton at apple.com> ---
Comment on attachment 366370
  --> https://bugs.webkit.org/attachment.cgi?id=366370
Fixes the bug

View in context: https://bugs.webkit.org/attachment.cgi?id=366370&action=review

> Source/WebKit/WebProcess/WebPage/WebPage.cpp:5317
>  {
> -    if (!m_focusedElement)
> +    if (!m_focusedElementForUserInput)
>	   return;

I'm not sure this rename is totally necessary, especially given that you didn't
rename all the things adjacent to it (like, say, this function).

> Source/WebKit/WebProcess/WebPage/WebPage.cpp:5356
> +    return is<HTMLSelectElement>(element) ||
isTextFormControlOrEditableContent(element);

This seems ... like an oddly small set of cases? Or maybe the function name is
wrong? Any element "may require user input" if it responds to events?