[webkit-reviews] review granted: [Bug 196392] [JSC] JSWrapperMap should not use Objective-C Weak map (NSMapTable with NSPointerFunctionsWeakMemory) for m_cachedObjCWrappers : [Attachment 366320] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Yusuke Suzuki <ysuzuki at apple.com>'s
request for review:
Bug 196392: [JSC] JSWrapperMap should not use Objective-C Weak map (NSMapTable
with NSPointerFunctionsWeakMemory) for m_cachedObjCWrappers
https://bugs.webkit.org/show_bug.cgi?id=196392

Attachment 366320: Patch

https://bugs.webkit.org/attachment.cgi?id=366320&action=review




--- Comment #4 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 366320
  --> https://bugs.webkit.org/attachment.cgi?id=366320
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=366320&action=review

> Source/JavaScriptCore/API/JSWrapperMap.mm:604
> +    void* m_wrapper { nullptr };

As you mentioned, let's use __unsafe_unretained