[webkit-reviews] review granted: [Bug 196325] B3ReduceStrength should know that Mul distributes over Add and Sub : [Attachment 366127] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 29 16:18:09 PDT 2019


Michael Saboff <msaboff at apple.com> has granted Robin Morisset
<rmorisset at apple.com>'s request for review:
Bug 196325: B3ReduceStrength should know that Mul distributes over Add and Sub
https://bugs.webkit.org/show_bug.cgi?id=196325

Attachment 366127: Patch

https://bugs.webkit.org/attachment.cgi?id=366127&action=review




--- Comment #2 from Michael Saboff <msaboff at apple.com> ---
Comment on attachment 366127
  --> https://bugs.webkit.org/attachment.cgi?id=366127
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=366127&action=review

r=me with comment

> Source/JavaScriptCore/b3/B3ReduceStrength.cpp:2439
> -	       replaceWithNew<Value>(BitAnd, m_value->origin(), bitOp, x1);
> +	       replaceWithNew<Value>(BitAnd, m_value->origin(), x1, bitOp);

This change isn't described in the ChangeLog.


More information about the webkit-reviews mailing list