[webkit-reviews] review granted: [Bug 196266] Web Inspector: Elements tab: Classes toggle should use accent color on hover : [Attachment 365986] Patch

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has granted Matt Baker <mattbaker at apple.com>'s
request for review:
Bug 196266: Web Inspector: Elements tab: Classes toggle should use accent color
on hover
https://bugs.webkit.org/show_bug.cgi?id=196266

Attachment 365986: Patch

https://bugs.webkit.org/attachment.cgi?id=365986&action=review




--- Comment #8 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 365986
  --> https://bugs.webkit.org/attachment.cgi?id=365986
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=365986&action=review

rs=me

>
Source/WebInspectorUI/UserInterface/Views/GeneralStyleDetailsSidebarPanel.css:1
16
> +    content: "";

NIT: I normally put `content` after `width`/`height` (e.g. sizing), but before
`border` (e.g. outside of the content).

>
Source/WebInspectorUI/UserInterface/Views/GeneralStyleDetailsSidebarPanel.css:1
18
> +    left: 0;
> +    top: 0;

NIT: the order of these should be reversed.  I match the order of the
shorthand=>longhand values (top right bottom left).

>
Source/WebInspectorUI/UserInterface/Views/GeneralStyleDetailsSidebarPanel.css:1
23
> +    z-index: -1;

NIT: I normally put `z-index` alongside other "positional" properties (e.g.
`top`, `left`).