[webkit-reviews] review granted: [Bug 196404] [Simple line layout] Turn off inline boxtree generation for multiline content : [Attachment 366296] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted zalan
<zalan at apple.com>'s request for review:
Bug 196404: [Simple line layout] Turn off inline boxtree generation for
multiline content
https://bugs.webkit.org/show_bug.cgi?id=196404

Attachment 366296: Patch

https://bugs.webkit.org/attachment.cgi?id=366296&action=review




--- Comment #3 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 366296
  --> https://bugs.webkit.org/attachment.cgi?id=366296
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=366296&action=review

> Source/WebCore/ChangeLog:9
> +	   Currently simple line layout can't provide the correct line breaking
context to the inline boxtree when the boxtree is

inline tree?

> Source/WebCore/ChangeLog:10
> +	   generated using the simple line runs. This patch limits the
generation of such trees to single line. Multiline content will

to single lines

> LayoutTests/fast/text/simple-line-layout-and-multiline-inlineboxtree.html:7
> +    internals.settings.setSimpleLineLayoutDebugBordersEnabled(true);

remove