[webkit-reviews] review granted: [Bug 196378] REGRESSION (r243250): Text interactions are no longer suppressed when editing in some websites : [Attachment 366245] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 29 11:57:03 PDT 2019


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 196378: REGRESSION (r243250): Text interactions are no longer suppressed
when editing in some websites
https://bugs.webkit.org/show_bug.cgi?id=196378

Attachment 366245: Patch

https://bugs.webkit.org/attachment.cgi?id=366245&action=review




--- Comment #2 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 366245
  --> https://bugs.webkit.org/attachment.cgi?id=366245
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=366245&action=review

>
LayoutTests/editing/selection/ios/hide-selection-in-textarea-with-transform.htm
l:41
> +function focusTextarea(overflow) {

{ on next line.

>
LayoutTests/editing/selection/ios/hide-selection-in-textarea-with-transform.htm
l:46
> +async function tapButtonAndWaitForKeyboard(button, caretShouldBeVisible) {

ditto


More information about the webkit-reviews mailing list