[webkit-reviews] review granted: [Bug 195374] Hit-testing of boxes over scrollers should account for border-radius : [Attachment 366251] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 29 11:08:14 PDT 2019


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Antti Koivisto
<koivisto at iki.fi>'s request for review:
Bug 195374: Hit-testing of boxes over scrollers should account for
border-radius
https://bugs.webkit.org/show_bug.cgi?id=195374

Attachment 366251: patch

https://bugs.webkit.org/attachment.cgi?id=366251&action=review




--- Comment #8 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 366251
  --> https://bugs.webkit.org/attachment.cgi?id=366251
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=366251&action=review

> Source/WebCore/page/Frame.h:118
>      LayerTreeFlagsIncludeBackingStoreAttached = 1 << 7,
>      LayerTreeFlagsIncludeRootLayerProperties = 1 << 8,
> +    LayerTreeFlagsIncludeEventRegion = 1 << 9,

The cool kids are lining up the "= ..." these days :)

> Source/WebCore/platform/graphics/GraphicsLayer.cpp:935
> +	   ts << indent << "(event region\n";
> +	   for (auto& rect : m_eventRegion.rects()) {
> +	       TextStream::IndentScope indentScope(ts);
> +	       ts << indent << "(rect " << rect.x() << " " << rect.y() << " "
<< rect.width() << " " << rect.height() << ")\n";
> +	   }
> +	   ts << indent << ")\n";

Please add and use TextStream& operator<<(TextStream&, const Region&)

> Source/WebCore/platform/graphics/RoundedRect.h:117
> +    // Approximate by snipping away half-radii sized rectangles from
corners.
> +    WEBCORE_EXPORT Region approximateAsRegion() const;

I think I'd prefer some kind of "stepping" function with a configurable step
size at some point.

> LayoutTests/ChangeLog:10
> +	   * fast/scrolling/ios/border-radious-event-region-expected.txt:
Added.
> +	   * fast/scrolling/ios/border-radious-event-region.html: Added.

Bad spelling


More information about the webkit-reviews mailing list