[webkit-reviews] review granted: [Bug 196128] Blob type cannot be stored correctly in IDB when IDBObjectStore has autoIncrement and keyPath options : [Attachment 366036] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Sihui Liu <sihui_liu at apple.com>'s
request for review:
Bug 196128: Blob type cannot be stored correctly in IDB when IDBObjectStore has
autoIncrement and keyPath options
https://bugs.webkit.org/show_bug.cgi?id=196128

Attachment 366036: Patch

https://bugs.webkit.org/attachment.cgi?id=366036&action=review




--- Comment #8 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 366036
  --> https://bugs.webkit.org/attachment.cgi?id=366036
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=366036&action=review

r=me, looks like you've addressed Youenn's comments

> Source/WebCore/Modules/indexeddb/IDBTransaction.cpp:877
> +	       auto urls = result.value().blobURLs();
> +	       auto paths = result.value().blobFilePaths();
> +	       for (auto& urlPath : injected.value().blobURLPathPairs) {
> +		   urls.append(WTFMove(urlPath.first));
> +		   paths.append(WTFMove(urlPath.second));
> +	       }

I'd like to think through a way to avoid duplicating this pattern. Maybe
there's a way to put it into an InjectionResult constructor or helper function.
Or maybe there's a way to represent it directly in our serialized/deserialized
form of an IDB result. But I don't have an immediate suggestion.