[webkit-reviews] review granted: [Bug 196359] CodeBlock::jettison() should disallow repatching its own calls : [Attachment 366192] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 28 13:33:58 PDT 2019

Saam Barati <sbarati at apple.com> has granted Tadeu Zagallo
<tzagallo at apple.com>'s request for review:
Bug 196359: CodeBlock::jettison() should disallow repatching its own calls

Attachment 366192: Patch


--- Comment #3 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 366192
  --> https://bugs.webkit.org/attachment.cgi?id=366192

View in context: https://bugs.webkit.org/attachment.cgi?id=366192&action=review

> Source/JavaScriptCore/ChangeLog:17
> +	   Change it so that we set a flag, `clearedByJettison`, in all the
> +	   owned by the CodeBlock being jettisoned. If the flag is set, we will
> +	   repatching the call during unlinking.

It took me a few minutes to agree that this is safe, but maybe it's worth
expanding on in a sentence or two. The beginning of this call should never be
reachable again after the CodeBlock is jettisoned.

More information about the webkit-reviews mailing list