[webkit-reviews] review granted: [Bug 196075] All PointerEvent.isTrusted is always false. : [Attachment 366161] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Mar 28 08:40:41 PDT 2019
Chris Dumez <cdumez at apple.com> has granted Antoine Quint <graouts at apple.com>'s
request for review:
Bug 196075: All PointerEvent.isTrusted is always false.
https://bugs.webkit.org/show_bug.cgi?id=196075
Attachment 366161: Patch
https://bugs.webkit.org/attachment.cgi?id=366161&action=review
--- Comment #5 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 366161
--> https://bugs.webkit.org/attachment.cgi?id=366161
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=366161&action=review
r=me with comments.
> Source/WebCore/dom/PointerEvent.cpp:87
> +Ref<PointerEvent> PointerEvent::createPointerCancelEvent(PointerID
pointerId, String pointerType)
const String& or maybe const AtomicString&.
> Source/WebCore/dom/PointerEvent.cpp:115
> +PointerEvent::PointerEvent(const AtomicString& type, CanBubble canBubble,
IsCancelable isCancelable, IsComposed isComposed, PointerID pointerId, String
pointerType)
const String& or const AtomicString&, not String.
> Source/WebCore/dom/PointerEvent.h:76
> + static Ref<PointerEvent> createPointerCancelEvent(PointerID, String
pointerType);
const String& or const AtomicString&.
More information about the webkit-reviews
mailing list