[webkit-reviews] review granted: [Bug 196346] [GStreamer] imxvpudecoder detection and handling : [Attachment 366165] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 28 05:28:29 PDT 2019


Xabier Rodríguez Calvar <calvaris at igalia.com> has granted Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 196346: [GStreamer] imxvpudecoder detection and handling
https://bugs.webkit.org/show_bug.cgi?id=196346

Attachment 366165: Patch

https://bugs.webkit.org/attachment.cgi?id=366165&action=review




--- Comment #2 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 366165
  --> https://bugs.webkit.org/attachment.cgi?id=366165
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=366165&action=review

> Source/WebCore/ChangeLog:9
> +	   directviv-uploaded texure returns an RGB value, so there's no need

texture

> Source/WebCore/ChangeLog:11
> +	   ImageRotation flag handling. The flat is now computed once only

flag

>
Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
858
> +    bool shouldWait = m_videoDecoderPlatform ==
WebKitGstVideoDecoderPlatform::Video4Linux;
>      auto proxyOperation =
> -	   [shouldWait = m_isVideoDecoderVideo4Linux, pipeline =
pipeline()](TextureMapperPlatformLayerProxy& proxy)
> +	   [shouldWait, pipeline = pipeline()](TextureMapperPlatformLayerProxy&
proxy)

nit: is there any problem in using this in one line?

>
Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:29
4
> +    mutable WebKitGstVideoDecoderPlatform m_videoDecoderPlatform;

Does this need to be mutable?


More information about the webkit-reviews mailing list