[webkit-reviews] review canceled: [Bug 196343] Opcode.h(159, 27): warning: adding 'unsigned int' to a string does not append to the string [-Wstring-plus-int] : [Attachment 366159] Patch

[bugzilla-daemon at webkit.org]

Fujii Hironori <Hironori.Fujii at sony.com> has canceled Fujii Hironori
<Hironori.Fujii at sony.com>'s request for review:
Bug 196343: Opcode.h(159,27): warning: adding 'unsigned int' to a string does
not append to the string [-Wstring-plus-int]
https://bugs.webkit.org/show_bug.cgi?id=196343

Attachment 366159: Patch

https://bugs.webkit.org/attachment.cgi?id=366159&action=review




--- Comment #5 from Fujii Hironori <Hironori.Fujii at sony.com> ---
Comment on attachment 366159
  --> https://bugs.webkit.org/attachment.cgi?id=366159
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=366159&action=review

> Source/JavaScriptCore/bytecode/Opcode.cpp:63
> +    return &padding[stringLength - width];

out-of-bound access occurs if the opcode name is longer than width.