[webkit-reviews] review granted: [Bug 196324] Web Inspector: Canvas: unbinding a canvas should always remove the agent as an observer : [Attachment 366119] Patch

[bugzilla-daemon at webkit.org]

Matt Baker <mattbaker at apple.com> has granted Devin Rousso <drousso at apple.com>'s
request for review:
Bug 196324: Web Inspector: Canvas: unbinding a canvas should always remove the
agent as an observer
https://bugs.webkit.org/show_bug.cgi?id=196324

Attachment 366119: Patch

https://bugs.webkit.org/attachment.cgi?id=366119&action=review




--- Comment #3 from Matt Baker <mattbaker at apple.com> ---
Comment on attachment 366119
  --> https://bugs.webkit.org/attachment.cgi?id=366119
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=366119&action=review

r=me

> Source/WebCore/html/CanvasBase.cpp:74
>	   observer->canvasChanged(*this, rect);

I noticed this is a widely used pattern in WebKit. Is it to safeguard against
m_observers mutating during iteration?