[webkit-reviews] review granted: [Bug 196308] Add another status-bubble iframe to display results from new EWS : [Attachment 366089] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 27 13:57:13 PDT 2019


Lucas Forschler <lforschler at apple.com> has granted Aakash Jain
<aakash_jain at apple.com>'s request for review:
Bug 196308: Add another status-bubble iframe to display results from new EWS
https://bugs.webkit.org/show_bug.cgi?id=196308

Attachment 366089: Patch

https://bugs.webkit.org/attachment.cgi?id=366089&action=review




--- Comment #4 from Lucas Forschler <lforschler at apple.com> ---
Comment on attachment 366089
  --> https://bugs.webkit.org/attachment.cgi?id=366089
Patch

is there any easy way to pull our these URLs into a constant variable and
reference that in the code? If we ever change the url, it would make it much
easier to update.
I think we should consider this for both https://ews.webkit.org and
webkit-queues.webkit.org.


More information about the webkit-reviews mailing list