[webkit-reviews] review granted: [Bug 196313] validateOSREntryValue with Int52 should box the value being checked into double format : [Attachment 366099] patch

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <ysuzuki at apple.com> has granted Saam Barati <sbarati at apple.com>'s
request for review:
Bug 196313: validateOSREntryValue with Int52 should box the value being checked
into double format
https://bugs.webkit.org/show_bug.cgi?id=196313

Attachment 366099: patch

https://bugs.webkit.org/attachment.cgi?id=366099&action=review




--- Comment #3 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 366099
  --> https://bugs.webkit.org/attachment.cgi?id=366099
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=366099&action=review

r=me

> Source/JavaScriptCore/dfg/DFGOSREntry.cpp:217
>	       // Constant AnyInt value is stored as usual boxed value in
AbstractValue.

We can change this comment like,

Constant AnyInt value is represented as SpecAnyIntAsDouble value in DFG.

> Source/JavaScriptCore/dfg/DFGOSREntry.cpp:219
>	       format = FlushedInt52;
> +	       value = jsDoubleNumber(value.asAnyInt());

You can exchange these two lines to align them to the code for FlushedDouble
case.