[webkit-reviews] review granted: [Bug 196173] Need a way to include WebKitAdditions code in WebKit API headers : [Attachment 365820] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 196173: Need a way to include WebKitAdditions code in WebKit API headers
https://bugs.webkit.org/show_bug.cgi?id=196173

Attachment 365820: Patch

https://bugs.webkit.org/attachment.cgi?id=365820&action=review




--- Comment #5 from Tim Horton <thorton at apple.com> ---
Comment on attachment 365820
  --> https://bugs.webkit.org/attachment.cgi?id=365820
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=365820&action=review

This is 😡 but OK. For now.

> Source/WebKit/mac/replace-webkit-additions-includes.py:35
> +	   file_in_build_directory = open("%s/%s" % (built_products_directory,
additions_path), "r")

os.path.join (in a bunch of places)

> Source/WebKit/mac/replace-webkit-additions-includes.py:75
> +		   print "(%s): failed to write to file: %s" % (argv[0],
header_path)

print as a function? what happens with python3? do we care? I don't know?