[webkit-reviews] review granted: [Bug 196244] [GStreamer] Remove the HLS queue buffering query hack : [Attachment 365959] Patch

[bugzilla-daemon at webkit.org]

Xabier Rodríguez Calvar <calvaris at igalia.com> has granted Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 196244: [GStreamer] Remove the HLS queue buffering query hack
https://bugs.webkit.org/show_bug.cgi?id=196244

Attachment 365959: Patch

https://bugs.webkit.org/attachment.cgi?id=365959&action=review




--- Comment #2 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 365959
  --> https://bugs.webkit.org/attachment.cgi?id=365959
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=365959&action=review

>
Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:1592
> +	   gst_query_parse_buffering_range(query.get(), nullptr, nullptr,
&stop, nullptr);

Would it make sense to get the format and ASSERT it is PERCENT?