[webkit-reviews] review granted: [Bug 196282] Fix some more deprecation warnings in WKDrawingView : [Attachment 366032] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 26 18:46:57 PDT 2019

Wenson Hsieh <wenson_hsieh at apple.com> has granted Tim Horton
<thorton at apple.com>'s request for review:
Bug 196282: Fix some more deprecation warnings in WKDrawingView

Attachment 366032: Patch


--- Comment #2 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 366032
  --> https://bugs.webkit.org/attachment.cgi?id=366032

View in context: https://bugs.webkit.org/attachment.cgi?id=366032&action=review

> Source/WebKit/UIProcess/ios/WKDrawingCoordinator.mm:35
> +#import <WebKitAdditions/WKDrawingCoordinatorAdditions.mm>

Nit - may consider a #if USE(APPLE_INTERNAL_SDK) here, though it's probably not
necessary since HAVE(PENCILKIT) is off in all non-internal SDKs, and probably
by the time that's no longer the case you would've already moved the code into
open source :)

More information about the webkit-reviews mailing list