[webkit-reviews] review denied: [Bug 194607] Web Inspector: CSS Changes: resetting value still shows in the diff : [Attachment 365897] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 26 15:47:55 PDT 2019

Nikita Vasilyev <nvasilyev at apple.com> has denied Nikita Vasilyev
<nvasilyev at apple.com>'s request for review:
Bug 194607: Web Inspector: CSS Changes: resetting value still shows in the diff

Attachment 365897: Patch


--- Comment #12 from Nikita Vasilyev <nvasilyev at apple.com> ---
Comment on attachment 365897
  --> https://bugs.webkit.org/attachment.cgi?id=365897

There are a couple more CSS Changes bugs:
- Bug 195264 - Web Inspector: CSS Changes: modifications aren't shared for
rules that match multiple elements
- Bug 196215 - Web Inspector: Green highlight disappears from edited properties
when adding a new property

To fix them, I'm going to try a different approach:

- Check property equality based on their content. Unfortunately, CSSProperty
instances sometimes get re-created with the same content and strict equality
checks of models doesn't work.
- Copy all properties of a style declaration on the first edit. Updating
`this._initialState.properties` on each edit turned out to be unnecessary
confusing and error-prone.

This different approach would make this patch above obsolete.

More information about the webkit-reviews mailing list