[webkit-reviews] review granted: [Bug 196270] [ews-build] Use PostgreSQL for ews.webkit.org database : [Attachment 365995] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 26 13:52:45 PDT 2019

Lucas Forschler <lforschler at apple.com> has granted Aakash Jain
<aakash_jain at apple.com>'s request for review:
Bug 196270: [ews-build] Use PostgreSQL for ews.webkit.org database

Attachment 365995: Patch


--- Comment #2 from Lucas Forschler <lforschler at apple.com> ---
Comment on attachment 365995
  --> https://bugs.webkit.org/attachment.cgi?id=365995

View in context: https://bugs.webkit.org/attachment.cgi?id=365995&action=review

r+ with assignment fix.

> Tools/BuildSlaveSupport/ews-app/ews-app/settings.py:115
> +	   }

these are mis-aligned by one char.
if we are leaving PORT as empty, do we need to include it at all?

More information about the webkit-reviews mailing list