[webkit-reviews] review granted: [Bug 196264] [iOS][WK2] Use a better concept to describe the reason we defer zooming a focused element: selectabiltiy : [Attachment 365982] Patch

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted Daniel Bates
<dbates at webkit.org>'s request for review:
Bug 196264: [iOS][WK2] Use a better concept to describe the reason we defer
zooming a focused element: selectabiltiy
https://bugs.webkit.org/show_bug.cgi?id=196264

Attachment 365982: Patch

https://bugs.webkit.org/attachment.cgi?id=365982&action=review




--- Comment #4 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 365982
  --> https://bugs.webkit.org/attachment.cgi?id=365982
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=365982&action=review

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:4808
> +static bool mayBeSelectable(WebKit::InputType type)

Nit - mayContainSelectableText?

>> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:4835
>> +	case WebKit::InputType::Week:
> 
> Note that this is a new case. Old code didn't consider Week, but we should.
It acts like a text field (or at least does on the Mac). This type appears to
behave weirdly on iOS currently. We need to fix bug #158327.

Nit - maybe leave a FIXME referencing the bug number (158327) here/