[webkit-reviews] review granted: [Bug 196243] Primary cluster of measurement set should always contain latest point. : [Attachment 365948] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 26 11:33:27 PDT 2019


Ryosuke Niwa <rniwa at webkit.org> has granted dewei_zhu at apple.com's request for
review:
Bug 196243: Primary cluster of measurement set should always contain latest
point.
https://bugs.webkit.org/show_bug.cgi?id=196243

Attachment 365948: Patch

https://bugs.webkit.org/attachment.cgi?id=365948&action=review




--- Comment #2 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 365948
  --> https://bugs.webkit.org/attachment.cgi?id=365948
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=365948&action=review

> Websites/perf.webkit.org/server-tests/api-measurement-set-tests.js:468
> +	   const currentRows = response['configurations']['current'];

Can we also check that these times are earlier than the cluster start time,
etc...?


More information about the webkit-reviews mailing list