[webkit-reviews] review granted: [Bug 196255] [ews-build] Get master_hostname dynamically in master.cfg : [Attachment 365967] Patch

[bugzilla-daemon at webkit.org]

Lucas Forschler <lforschler at apple.com> has granted Aakash Jain
<aakash_jain at apple.com>'s request for review:
Bug 196255: [ews-build] Get master_hostname dynamically in master.cfg
https://bugs.webkit.org/show_bug.cgi?id=196255

Attachment 365967: Patch

https://bugs.webkit.org/attachment.cgi?id=365967&action=review




--- Comment #2 from Lucas Forschler <lforschler at apple.com> ---
Comment on attachment 365967
  --> https://bugs.webkit.org/attachment.cgi?id=365967
Patch

I think we should use pythons optimized code here instead of calling out to
shell.
import socket
socket.gethostname()
or
socket.getfqdn()

I don't feel too strongly about it, so I'll r+ this, but in general I would
guess it's more efficient.