[webkit-reviews] review granted: [Bug 195996] Geolocation request not complete when watch request was started in a different web process : [Attachment 365809] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 25 14:17:10 PDT 2019


Alex Christensen <achristensen at apple.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 195996: Geolocation request not complete when watch request was started in
a different web process
https://bugs.webkit.org/show_bug.cgi?id=195996

Attachment 365809: Patch

https://bugs.webkit.org/attachment.cgi?id=365809&action=review




--- Comment #15 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 365809
  --> https://bugs.webkit.org/attachment.cgi?id=365809
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=365809&action=review

> Tools/TestWebKitAPI/Tests/WebKit/Geolocation.cpp:320
> +    std::string alertText;

Nit: I see no reason not to use WTF::String here.


More information about the webkit-reviews mailing list