[webkit-reviews] review granted: [Bug 196208] [GTK][WPE] Disable process warming : [Attachment 365877] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Patrick Griffis
<pgriffis at igalia.com>'s request for review:
Bug 196208: [GTK][WPE] Disable process warming
https://bugs.webkit.org/show_bug.cgi?id=196208

Attachment 365877: Patch

https://bugs.webkit.org/attachment.cgi?id=365877&action=review




--- Comment #5 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 365877
  --> https://bugs.webkit.org/attachment.cgi?id=365877
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=365877&action=review

r=me

> Source/WebKit/UIProcess/glib/WebProcessPoolGLib.cpp:90
> +    // Process warming is incompatible with the fact our
WebProcessProxy::platformGetLaunchOptions()

You may want a FIXME comment as the performance of process-swap-on-navigation
is not going to be great without process-prewarming.