[webkit-reviews] review granted: [Bug 196085] Remove the SVG tear off objects for SVGPathSeg, SVGPathSegList and SVGAnimatedPathSegList : [Attachment 365733] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 25 11:55:25 PDT 2019


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Said Abou-Hallawa
<sabouhallawa at apple.com>'s request for review:
Bug 196085: Remove the SVG tear off objects for SVGPathSeg, SVGPathSegList and
SVGAnimatedPathSegList
https://bugs.webkit.org/show_bug.cgi?id=196085

Attachment 365733: Patch

https://bugs.webkit.org/attachment.cgi?id=365733&action=review




--- Comment #5 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 365733
  --> https://bugs.webkit.org/attachment.cgi?id=365733
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=365733&action=review

> Source/WebCore/svg/properties/SVGAnimatedPropertyAnimatorImpl.h:123
> +	   return std::unique_ptr<SVGAnimatedPathSegListAnimator>(new
SVGAnimatedPathSegListAnimator(attributeName, animated, animationMode,
calcMode, isAccumulated, isAdditive));

make_unique<>


More information about the webkit-reviews mailing list