[webkit-reviews] review granted: [Bug 175691] WebAssembly: max with NaN generates incorrect result : [Attachment 365807] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 25 11:35:51 PDT 2019


Saam Barati <sbarati at apple.com> has granted Tadeu Zagallo
<tzagallo at apple.com>'s request for review:
Bug 175691: WebAssembly: max with NaN generates incorrect result
https://bugs.webkit.org/show_bug.cgi?id=175691

Attachment 365807: Patch

https://bugs.webkit.org/attachment.cgi?id=365807&action=review




--- Comment #9 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 365807
  --> https://bugs.webkit.org/attachment.cgi?id=365807
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=365807&action=review

> Source/JavaScriptCore/wasm/WasmAirIRGenerator.cpp:2820
> +    append(isNaN, AddFloat, arg0, arg1, result);

Why do we need this add?

> JSTests/wasm/wasm.json:156
> +	   "f32.max":		  { "category": "arithmetic", "value": 151,
"return": ["f32"],	"parameter": ["f32", "f32"],	       "immediate": [],
"b3op": "Select(Equal(@0, @1), BitAnd(@0, @1), Select(LessThan(@0, @1), @1,
Select(GreaterThan(@0, @1), @0, Add(@0, @1))))" },

Why do we have two copies of this?


More information about the webkit-reviews mailing list