[webkit-reviews] review granted: [Bug 196180] [Apple Pay] Remove the AvailablePaymentNetworks synchronous message : [Attachment 365837] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 25 08:41:43 PDT 2019

youenn fablet <youennf at gmail.com> has granted Andy Estes <aestes at apple.com>'s
request for review:
Bug 196180: [Apple Pay] Remove the AvailablePaymentNetworks synchronous message

Attachment 365837: Patch


--- Comment #3 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 365837
  --> https://bugs.webkit.org/attachment.cgi?id=365837

View in context: https://bugs.webkit.org/attachment.cgi?id=365837&action=review

> Source/WebKit/WebProcess/ApplePay/cocoa/WebPaymentCoordinatorCocoa.mm:46
> +	   result.uncheckedAppend(network);

Can we add them to m_availablePaymentNetworks directly and return void?
Or better, return a AvailablePaymentNetworksSet directly and make this a free
function or a static WebPaymentCoordinator one.
We could also change WebPaymentCoordinator::availablePaymentNetworks():
if (!m_availablePaymentNetworks)
    m_availablePaymentNetworks = platformAvailablePaymentNetworks();
return *m_availablePaymentNetworks;

> Source/WebKit/WebProcess/WebPage/mac/WKAccessibilityWebPageObjectBase.mm:133
> +    if (WebCore::AXObjectCache* cache = [self axObjectCache]) {


More information about the webkit-reviews mailing list